Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests on Travis and test also on 2.5 #3

Closed
wants to merge 7 commits into from
Closed

Fix tests on Travis and test also on 2.5 #3

wants to merge 7 commits into from

Conversation

Masa331
Copy link

@Masa331 Masa331 commented Nov 25, 2018

Hi,

fixes tests on Travis and adds 2.5v to test matrix. Could you please then merge #2?

Have a nice day,

@Masa331
Copy link
Author

Masa331 commented Nov 25, 2018

Erm i don't know for how long the Travis wasn't working but there are more errors the more we go to history with Ruby versions. I suggest to drop support for all Rubies < 2.1 since 2.1 is the version where Array#to_h was added. If only supported Rubies are > 2.1 then there is no need to make changes to codebase

@Masa331 Masa331 closed this by deleting the head repository Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant